Add basics/close-account/poseidon #161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yangatech
reviewed
Oct 22, 2024
Yangatech
left a comment
Yangatech
left a comment
There was a problem hiding this comment.
Instead of using u8 for the name field, consider using a String or a fixed-size byte array for more practical usage. Ensure the allocated account space matches the actual size needed for the UserAccount struct. Add logging with msg! to track key actions like account creation and closure.
Yangatech
suggested changes
Oct 22, 2024
There was a problem hiding this comment.
storing the name as a u8 may limit usability; switching to a string or byte array would be better.
This comment was marked as abuse.
This comment was marked as abuse.
|
Ohh okay thank you so much for your feedback
…On Tue, 22 Oct 2024 at 5:51 PM, The Maker ***@***.***> wrote:
Poseidon does not currently support strings or fixed sized byte arrays so
i did that to improvise, i think its best i removed it, also poseidon does
not support msg()! macro
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ6ZEVW5RFJHKJ6KWT7Z3FTZ4Z7A7AVCNFSM6AAAAABQIRQHFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZG44DINRUGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
heyAyushh
added
contribute:poseidon
added 9 commits
November 25, 2024 09:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.